[webkit-reviews] review granted: [Bug 184904] dlopen the bundle's executable before calling -[NSBundle load] since that will also do a bunch of other things we don't need : [Attachment 338692] patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 184904: dlopen the bundle's executable before calling -[NSBundle load]
since that will also do a bunch of other things we don't need
https://bugs.webkit.org/show_bug.cgi?id=184904

Attachment 338692: patch

https://bugs.webkit.org/attachment.cgi?id=338692&action=review




--- Comment #7 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 338692
  --> https://bugs.webkit.org/attachment.cgi?id=338692
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338692&action=review

r=me

> Source/WebKit/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:94
> +    if (!dlopenHandle || !initializeFunction) {

I think it's better just to check !initializeFunction here and below, and to
scope dlopenHandle to inside the if block.

Logically, we want to fall back if we didn't find the initialize function,
regardless of why we didn't find it -- and if we did find it, we don't need to
fall back and we don't care about other details.