[webkit-reviews] review granted: [Bug 184926] Auto save the results for Test262 : [Attachment 338668] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 25 13:05:19 PDT 2018


Michael Saboff <msaboff at apple.com> has granted Leo Balter
<leonardo.balter at gmail.com>'s request for review:
Bug 184926: Auto save the results for Test262
https://bugs.webkit.org/show_bug.cgi?id=184926

Attachment 338668: Patch

https://bugs.webkit.org/attachment.cgi?id=338668&action=review




--- Comment #3 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 338668
  --> https://bugs.webkit.org/attachment.cgi?id=338668
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338668&action=review

r=me with one suggested text change.

> Tools/Scripts/test262/Runner.pm:306
> +	   print "\nSaved results in: $expectationsFile\n";

Please change this message to something like "Saved new expectations in :"


More information about the webkit-reviews mailing list