[webkit-reviews] review granted: [Bug 184948] Don't Block First Party Cookies on Redirects : [Attachment 338761] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 184948: Don't Block First Party Cookies on Redirects
https://bugs.webkit.org/show_bug.cgi?id=184948

Attachment 338761: Patch

https://bugs.webkit.org/attachment.cgi?id=338761&action=review




--- Comment #14 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 338761
  --> https://bugs.webkit.org/attachment.cgi?id=338761
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338761&action=review

> Source/WebKit/NetworkProcess/NetworkDataTaskBlob.h:57
> +    NetworkDataTaskBlob(NetworkSession&, NetworkDataTaskClient&, const
WebCore::ResourceRequest&, WebCore::ContentSniffingPolicy, const
Vector<RefPtr<WebCore::BlobDataFileReference>>&, bool);

It does not seem isMainFrameNavigation is useful for blobs since there are no
redirections in that case.

> Source/WebKit/NetworkProcess/NetworkLoadParameters.h:51
> +    bool isMainFrameNavigation { false };

Seems good for now.
I wonder though whether we do not add some redundant information since
resourceRequest.requester also has that same information.
Can we try to use that information instead?
At least, we should add some ASSERT in WebLoaderStrategy.
It seems to me that isMainFrameNavigation is more robust since we do not mess
as much with requests.