[webkit-reviews] review granted: [Bug 184974] [LFC] Implement Layout::Box functions. : [Attachment 338745] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 184974: [LFC] Implement Layout::Box functions.
https://bugs.webkit.org/show_bug.cgi?id=184974

Attachment 338745: Patch

https://bugs.webkit.org/attachment.cgi?id=338745&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 338745
  --> https://bugs.webkit.org/attachment.cgi?id=338745
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338745&action=review

> Source/WebCore/layout/layouttree/LayoutBox.h:93
> +    WeakPtr<RenderElement> m_renderer;

I'm not sure that having a pointer to old render objects is good even as a
temporary measure. It might get difficult to untangle.

> Source/WebCore/layout/layouttree/LayoutBox.h:97
> +    WeakPtr<Box> m_nextSibling;
> +    WeakPtr<Box> m_previousSibling;

The basic tree structure probably shouldn't use weak ptrs.