[webkit-reviews] review granted: [Bug 184919] AX: soft link libAccessibility.dylb : [Attachment 338706] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 24 21:49:51 PDT 2018


mitz at webkit.org has granted Nan Wang <n_wang at apple.com>'s request for review:
Bug 184919: AX: soft link libAccessibility.dylb
https://bugs.webkit.org/show_bug.cgi?id=184919

Attachment 338706: patch

https://bugs.webkit.org/attachment.cgi?id=338706&action=review




--- Comment #10 from mitz at webkit.org ---
Comment on attachment 338706
  --> https://bugs.webkit.org/attachment.cgi?id=338706
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338706&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:706
> +	  
CFNotificationCenterAddObserver(CFNotificationCenterGetDarwinNotifyCenter(),
(__bridge const void *)(self), accessibilityEventsEnabledChangedCallback,
kAXSWebAccessibilityEventsEnabledNotification, 0,
CFNotificationSuspensionBehaviorDeliverImmediately);

Not new to this patch, but why is it OK to add this observer and never remove
it?


More information about the webkit-reviews mailing list