[webkit-reviews] review granted: [Bug 184952] fromCharCode is missing some exception checks : [Attachment 338699] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 184952: fromCharCode is missing some exception checks
https://bugs.webkit.org/show_bug.cgi?id=184952

Attachment 338699: Patch

https://bugs.webkit.org/attachment.cgi?id=338699&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 338699
  --> https://bugs.webkit.org/attachment.cgi?id=338699
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338699&action=review

> JSTests/stress/fromCharCode-exception-check.js:5
> +} catch (e) { }

probably worth checking the exception type here