[webkit-reviews] review denied: [Bug 184919] AX: soft link libAccessibility.dylb : [Attachment 338655] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 24 14:51:19 PDT 2018
mitz at webkit.org has denied review:
Bug 184919: AX: soft link libAccessibility.dylb
https://bugs.webkit.org/show_bug.cgi?id=184919
Attachment 338655: patch
https://bugs.webkit.org/attachment.cgi?id=338655&action=review
--- Comment #4 from mitz at webkit.org ---
Comment on attachment 338655
--> https://bugs.webkit.org/attachment.cgi?id=338655
patch
This is not an appropriate way to resolve this sort of issue. The correct fix
would have been to use $(WK_MACOS_WEAK_FRAMEWORK) instead of -framework, and to
perform the appropriate nil checks.
More information about the webkit-reviews
mailing list