[webkit-reviews] review denied: [Bug 184891] [WinCairo] Fix js/regexp-unicode.html crash. : [Attachment 338594] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has denied Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 184891: [WinCairo] Fix js/regexp-unicode.html crash.
https://bugs.webkit.org/show_bug.cgi?id=184891

Attachment 338594: Patch

https://bugs.webkit.org/attachment.cgi?id=338594&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 338594
  --> https://bugs.webkit.org/attachment.cgi?id=338594
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338594&action=review

> Source/JavaScriptCore/ChangeLog:10
> +	   MSVC evidently can't handle __forceinline here. 

Can you please explain why __forceinline would result in a crash in the first
place?	It doesn't make sense that a change in inlining behavior would resolve
a crash short of working around a compiler bug.  You'll need to provide proof
if that is the case.