[webkit-reviews] review granted: [Bug 184773] In FTLLowerDFGToB3.cpp::compileCreateRest, always use a contiguous array as the indexing type when under isWatchingHavingABadTimeWatchpoint : [Attachment 338320] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 23 06:45:05 PDT 2018


Filip Pizlo <fpizlo at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 184773: In FTLLowerDFGToB3.cpp::compileCreateRest, always use a contiguous
array as the indexing type when under isWatchingHavingABadTimeWatchpoint
https://bugs.webkit.org/show_bug.cgi?id=184773

Attachment 338320: Patch

https://bugs.webkit.org/attachment.cgi?id=338320&action=review




--- Comment #2 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 338320
  --> https://bugs.webkit.org/attachment.cgi?id=338320
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338320&action=review

R=me with that change.

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:5284
> +	       RegisteredStructure structure =
m_graph.registerStructure(globalObject->originalArrayStructureForIndexingType(A
rrayWithContiguous));

I think it would be better if you added a JSGlobalObject helper method called
originalRestParameterStructure. I think we have the restParameterStructure
method to abstract the fact that it’s just the contiguous array structure.  It
would be good if you also had such an abstraction for this case.


More information about the webkit-reviews mailing list