[webkit-reviews] review granted: [Bug 184844] Clients implementing _webView:focusShouldStartInputSession: can't easily express the "default" behavior : [Attachment 338539] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Apr 22 11:52:41 PDT 2018
mitz at webkit.org has granted Paul Knight <pknight at apple.com>'s request for
review:
Bug 184844: Clients implementing _webView:focusShouldStartInputSession: can't
easily express the "default" behavior
https://bugs.webkit.org/show_bug.cgi?id=184844
Attachment 338539: Patch
https://bugs.webkit.org/attachment.cgi?id=338539&action=review
--- Comment #5 from mitz at webkit.org ---
Comment on attachment 338539
--> https://bugs.webkit.org/attachment.cgi?id=338539
Patch
For something where there’s a default behavior and a way to customize it,
subclassing is usually nicer than delegation—you can just call super, if you
want, see “what would have happened”, and then customize the behavior.
More information about the webkit-reviews
mailing list