[webkit-reviews] review granted: [Bug 184863] [Modern Media Controls] Show a loading indicator after pressing the play button in compact mode : [Attachment 338530] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 184863: [Modern Media Controls] Show a loading indicator after pressing the
play button in compact mode
https://bugs.webkit.org/show_bug.cgi?id=184863

Attachment 338530: Patch

https://bugs.webkit.org/attachment.cgi?id=338530&action=review




--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 338530
  --> https://bugs.webkit.org/attachment.cgi?id=338530
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338530&action=review

Where is the test?

> Source/WebCore/ChangeLog:18
> +	   8 frames and then a continuously looping animation going through the
remaining frames. We use a frames()

first serious use of frames()? nice.

>
Source/WebCore/Modules/modern-media-controls/controls/compact-activity-indicato
r.css:33
> +    /* There are 23 frames in the sprite. */
> +    -webkit-mask-size: 2300% 100%;

If you want fully amazing CSS here.... --num-frames: 23; -webkit-mask-size:
calc(var(--num-frames) * 100%) 100%;