[webkit-reviews] review requested: [Bug 184861] Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected : [Attachment 338528] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 21 11:39:09 PDT 2018


Brian Burg <bburg at apple.com> has asked	for review:
Bug 184861: Web Inspector: opt out of process swap on navigation if a Web
Inspector frontend is connected
https://bugs.webkit.org/show_bug.cgi?id=184861

Attachment 338528: Patch

https://bugs.webkit.org/attachment.cgi?id=338528&action=review




--- Comment #1 from Brian Burg <bburg at apple.com> ---
Created attachment 338528

  --> https://bugs.webkit.org/attachment.cgi?id=338528&action=review

Patch

For some reason this always crashes under WKInpectorClose() when we send
-_apiObject inside unwrap(). But when I pause in the debugger in Safari, the
wrapper is always allocated and valid. I'm not quite sure what's going on with
the API test.


More information about the webkit-reviews mailing list