[webkit-reviews] review granted: [Bug 184841] Activate NetworkLoadChecker for media loads : [Attachment 338484] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 184841: Activate NetworkLoadChecker for media loads
https://bugs.webkit.org/show_bug.cgi?id=184841

Attachment 338484: Patch

https://bugs.webkit.org/attachment.cgi?id=338484&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 338484
  --> https://bugs.webkit.org/attachment.cgi?id=338484
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338484&action=review

> Source/WebKit/Shared/WebCoreArgumentCoders.cpp:1274
> +    if (resourceError.isNull())
> +	   return;

Nit: is it worth adding an ASSERT(resourceError.type() ==
ResourceError::Type::Null) when resourceError.isNull()?