[webkit-reviews] review granted: [Bug 184854] Render a badge on system preview images : [Attachment 338503] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 20 18:19:38 PDT 2018


Tim Horton <thorton at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 184854: Render a badge on system preview images
https://bugs.webkit.org/show_bug.cgi?id=184854

Attachment 338503: Patch

https://bugs.webkit.org/attachment.cgi?id=338503&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 338503
  --> https://bugs.webkit.org/attachment.cgi?id=338503
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338503&action=review

> Source/WebCore/rendering/RenderTheme.cpp:1374
> +    auto roundedMarkerRect = FloatRoundedRect { markerRect, { 8, 8 }, { 8, 8
}, { 8, 8 }, { 8, 8 } };

There is a single-float uniform radii constructor


More information about the webkit-reviews mailing list