[webkit-reviews] review granted: [Bug 184843] tex[Sub]Image2D slow when passing in a <canvas>, faster with ImageData : [Attachment 338475] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Justin Fan
<justin_fan at apple.com>'s request for review:
Bug 184843: tex[Sub]Image2D slow when passing in a <canvas>, faster with
ImageData
https://bugs.webkit.org/show_bug.cgi?id=184843

Attachment 338475: Patch

https://bugs.webkit.org/attachment.cgi?id=338475&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 338475
  --> https://bugs.webkit.org/attachment.cgi?id=338475
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338475&action=review

> Source/WebCore/platform/graphics/FormatConverter.cpp:1
> -/*
> +  /*

Ooops.

> Source/WebCore/platform/graphics/FormatConverter.cpp:1263
> +	   // FIXME: [34898868] Experimental Accelerate Alpha Unmultiplicaton
for this specific case; general performance improvements later.

I don't think this radar links adds anything.