[webkit-reviews] review granted: [Bug 184764] Limit cookie header access to the Network process : [Attachment 338477] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 20 16:08:10 PDT 2018


youenn fablet <youennf at gmail.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 184764: Limit cookie header access to the Network process
https://bugs.webkit.org/show_bug.cgi?id=184764

Attachment 338477: Patch

https://bugs.webkit.org/attachment.cgi?id=338477&action=review




--- Comment #35 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 338477
  --> https://bugs.webkit.org/attachment.cgi?id=338477
Patch

r=me as long as the bots are happy.

View in context: https://bugs.webkit.org/attachment.cgi?id=338477&action=review

> Source/WebCore/Modules/websockets/WebSocketChannel.cpp:283
> +	       if (m_document)

one if liner?

> Source/WebCore/platform/network/SocketStreamHandleImpl.cpp:94
> +    data.append('\n');

We could append a Vector of '\r\n\r\n' maybe


More information about the webkit-reviews mailing list