[webkit-reviews] review granted: [Bug 184846] Handle more JSON stringify OOM : [Attachment 338473] patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted JF Bastien <jfbastien at apple.com>'s
request for review:
Bug 184846: Handle more JSON stringify OOM
https://bugs.webkit.org/show_bug.cgi?id=184846

Attachment 338473: patch

https://bugs.webkit.org/attachment.cgi?id=338473&action=review




--- Comment #4 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 338473
  --> https://bugs.webkit.org/attachment.cgi?id=338473
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338473&action=review

r=me with fixes.

> Source/WTF/ChangeLog:9
> +	   JSON stringinfication can OOM easily. Here's another case.

typo: /stringinfication/stringification/.

> Source/WTF/ChangeLog:13
> +	   I'm working on a separate patch which teaches StringBuilder that
> +	   it's fallible, but that's way bigger and more complex, so I'll
> +	   commit it separately. It'll be much more comprehensive though!

I don't think you need to say this.

> Source/WTF/wtf/text/StringBuilderJSON.cpp:98
> +    if (is8Bit() && !string.is8Bit()) {

You don't need the curly brace here.

> Source/WTF/wtf/text/StringBuilderJSON.cpp:100
> +    } else

Ditto.