[webkit-reviews] review granted: [Bug 184786] Don't add system framework paths to FRAMEWORK_SEARCH_PATHS : [Attachment 338470] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 184786: Don't add system framework paths to FRAMEWORK_SEARCH_PATHS
https://bugs.webkit.org/show_bug.cgi?id=184786

Attachment 338470: Patch

https://bugs.webkit.org/attachment.cgi?id=338470&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 338470
  --> https://bugs.webkit.org/attachment.cgi?id=338470
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338470&action=review

> Source/WebCore/Configurations/WebCore.xcconfig:51
> +INSTALL_PATH = $(INSTALL_PATH_$(WK_PLATFORM_NAME));

This should totally use WK_COCOA_TOUCH

> Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:44
> -FRAMEWORK_SEARCH_PATHS[sdk=macosx*] = $(WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR)
"$(UMBRELLA_FRAMEWORKS_DIR)" $(inherited);
> +FRAMEWORK_SEARCH_PATHS[sdk=macosx*] = $(WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR)
$(UMBRELLA_FRAMEWORKS_DIR) $(inherited);

Where’d the quotes go