[webkit-reviews] review granted: [Bug 184835] Mandate H264 hardware encoder for Mac in libwebrtc : [Attachment 338459] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 184835: Mandate H264 hardware encoder for Mac in libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=184835

Attachment 338459: Patch

https://bugs.webkit.org/attachment.cgi?id=338459&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 338459
  --> https://bugs.webkit.org/attachment.cgi?id=338459
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338459&action=review

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolb
ox/RTCVideoEncoderH264.mm:615
> +  CFTypeRef sessionValues[] = { webrtc::isH264HardwareEncoderAllowed() ?
kCFBooleanTrue : kCFBooleanFalse, webrtc::isH264HardwareEncoderAllowed() ?
kCFBooleanTrue : kCFBooleanFalse, kCFBooleanTrue };

Nit: it seems slightly wasteful to call webrtc::isH264HardwareEncoderAllowed()
twice here.