[webkit-reviews] review denied: [Bug 184825] [iOS] LayoutTest http/tests/quicklook/hide-referer-on-navigation.html is failing : [Attachment 338435] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 184825: [iOS] LayoutTest
http/tests/quicklook/hide-referer-on-navigation.html is failing
https://bugs.webkit.org/show_bug.cgi?id=184825

Attachment 338435: Patch

https://bugs.webkit.org/attachment.cgi?id=338435&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 338435
  --> https://bugs.webkit.org/attachment.cgi?id=338435
Patch

I think you've got the diagnosis right here. That's great!

Let's re-use the "runAsync" flag to specify that we don't want UIHelper.wait()
to end the test early, rather than adding the "shouldWait" flag. I think the
flags philosophically mean the same thing -- with the exception that re-using
"runAsync" requires hide-referer-on-navigation.html to call
testRunner.waitUntilDone() itself before it calls runTest().