[webkit-reviews] review granted: [Bug 184833] [Simple line layout] Generate inline boxtree using simple line layout runs. : [Attachment 338446] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 184833: [Simple line layout] Generate inline boxtree using simple line
layout runs.
https://bugs.webkit.org/show_bug.cgi?id=184833

Attachment 338446: Patch

https://bugs.webkit.org/attachment.cgi?id=338446&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 338446
  --> https://bugs.webkit.org/attachment.cgi?id=338446
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338446&action=review

> Source/WebCore/rendering/SimpleLineLayoutFunctions.cpp:278
> +bool canUseForLineBoxTree(RenderBlockFlow& flow, const Layout& layout)
> +{
> +    return !layout.isPaginated() && !flow.style().preserveNewline() &&
flow.firstChild() && is<RenderText>(*flow.firstChild()) && flow.firstChild() ==
flow.lastChild();
> +}

This would be more readable with multiple lines and early returns.