[webkit-reviews] review granted: [Bug 184806] Fixes for timing out tests associated with switching Text Selection Assistants : [Attachment 338392] Patch

[bugzilla-daemon at webkit.org]

Beth Dakin <bdakin at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 184806: Fixes for timing out tests associated with switching Text Selection
Assistants
https://bugs.webkit.org/show_bug.cgi?id=184806

Attachment 338392: Patch

https://bugs.webkit.org/attachment.cgi?id=338392&action=review




--- Comment #3 from Beth Dakin <bdakin at apple.com> ---
Comment on attachment 338392
  --> https://bugs.webkit.org/attachment.cgi?id=338392
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338392&action=review

I don't think this should block committing this change since this change will
fix some tests, but is there any way to write a test to explicitly test that we
are allowing double tap at the right times? We should add a mechanism for that
kind of test if we don't have one already.

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1661
> +    if (gesture == UIWKGestureDoubleTap && !(self.isAssistingNode))

Do you need !(self.isAssistingNode) here? There is the early return just about
when self.isAssistingNode is true, so I wouldn't think you need it.