[webkit-reviews] review granted: [Bug 182225] Support calc() in webkit-gradient and cross-fade : [Attachment 332721] Change order of summary in changelogs

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Nardi
<cnardi at chromium.org>'s request for review:
Bug 182225: Support calc() in webkit-gradient and cross-fade
https://bugs.webkit.org/show_bug.cgi?id=182225

Attachment 332721: Change order of summary in changelogs

https://bugs.webkit.org/attachment.cgi?id=332721&action=review




--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 332721
  --> https://bugs.webkit.org/attachment.cgi?id=332721
Change order of summary in changelogs

View in context: https://bugs.webkit.org/attachment.cgi?id=332721&action=review

> Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:869
> +	   if (RefPtr<CSSPrimitiveValue> percentValue = consumePercent(args,
ValueRangeAll))

This could be if (auto percentValue = consumePercent(args, ValueRangeAll))

> Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:1231
> +    if (RefPtr<CSSPrimitiveValue> percentValue = consumePercent(args,
ValueRangeAll))
> +	   percentage =
CSSValuePool::singleton().createValue(clampTo<double>(percentValue->doubleValue
() / 100.0, 0, 1), CSSPrimitiveValue::UnitType::CSS_NUMBER);
> +    else if (RefPtr<CSSPrimitiveValue> numberValue = consumeNumber(args,
ValueRangeAll))

You could use auto here too.