[webkit-reviews] review granted: [Bug 184762] Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds : [Attachment 338344] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 19 11:37:08 PDT 2018


mitz at webkit.org has granted Jer Noble <jer.noble at apple.com>'s request for
review:
Bug 184762: Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for
engineering builds
https://bugs.webkit.org/show_bug.cgi?id=184762

Attachment 338344: Patch

https://bugs.webkit.org/attachment.cgi?id=338344&action=review




--- Comment #7 from mitz at webkit.org ---
Comment on attachment 338344
  --> https://bugs.webkit.org/attachment.cgi?id=338344
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338344&action=review

> Source/WebCore/PAL/Configurations/CopyPALHeaders.xcconfig:28
> +PRIVATE_HEADERS_FOLDER_PATH =
$(PAL_INSTALL_PATH_PREFIX)/usr/local/include/pal;

I think you end up with a harmless extra slash there.


More information about the webkit-reviews mailing list