[webkit-reviews] review granted: [Bug 184782] [Extra zoom mode] Add a mechanism to extend the height of the layout viewport in extra zoom mode : [Attachment 338339] Skip fast/visual-viewport/extrazoom

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 184782: [Extra zoom mode] Add a mechanism to extend the height of the
layout viewport in extra zoom mode
https://bugs.webkit.org/show_bug.cgi?id=184782

Attachment 338339: Skip fast/visual-viewport/extrazoom

https://bugs.webkit.org/attachment.cgi?id=338339&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 338339
  --> https://bugs.webkit.org/attachment.cgi?id=338339
Skip fast/visual-viewport/extrazoom

View in context: https://bugs.webkit.org/attachment.cgi?id=338339&action=review

> Source/WebCore/page/FrameView.cpp:1542
> +    return { baseLayoutViewportSize.width(),
std::min<LayoutUnit>(documentHeight, (1 + heightExpansionFactor) *
layoutViewportHeight) };

We might want to think about doing this is the horizontal direction too at some
point? But fixed-left/right and horizontal scrolling is not a big thing.

>
LayoutTests/fast/visual-viewport/extrazoom/layout-viewport-after-scrolling-and-
resizing.html:39
> +	       await UIHelper.ensurePresentationUpdate();

Maybe a comment! This shouldn’t be needed except for a bug. Which you should
file. And mention here.