[webkit-reviews] review denied: [Bug 184744] Propagate stack overflow and OOM when compiling builtins at runtime : [Attachment 338336] hacky patch, not for landing
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 19 10:10:37 PDT 2018
JF Bastien <jfbastien at apple.com> has denied review:
Bug 184744: Propagate stack overflow and OOM when compiling builtins at runtime
https://bugs.webkit.org/show_bug.cgi?id=184744
Attachment 338336: hacky patch, not for landing
https://bugs.webkit.org/attachment.cgi?id=338336&action=review
--- Comment #9 from JF Bastien <jfbastien at apple.com> ---
Created attachment 338336
--> https://bugs.webkit.org/attachment.cgi?id=338336&action=review
hacky patch, not for landing
Here's an updated patch which starts propagating some of the errors, but I
think we want to go with Robin's instead since he did the whole piping.
My patch also has a hacky thing to stack overflow after the VM initializes and
we start interpreting. It's of course a hack for testing.
More information about the webkit-reviews
mailing list