[webkit-reviews] review granted: [Bug 184619] AX: AOM: respect the accessibility setting for dispatching the accessible events : [Attachment 338239] patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Nan Wang <n_wang at apple.com>'s
request for review:
Bug 184619: AX: AOM: respect the accessibility setting for dispatching the
accessible events
https://bugs.webkit.org/show_bug.cgi?id=184619

Attachment 338239: patch

https://bugs.webkit.org/attachment.cgi?id=338239&action=review




--- Comment #34 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 338239
  --> https://bugs.webkit.org/attachment.cgi?id=338239
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338239&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:702
> +   
CFNotificationCenterAddObserver(CFNotificationCenterGetDarwinNotifyCenter(),
(__bridge const void *)(self), accessibilityEventsEnabledChangedCallback,
kAXSWebAccessibilityEventsEnabledNotification, 0,
CFNotificationSuspensionBehaviorDeliverImmediately);

You should add a WebKitAPI test which sends this notification to UI process.
You can do that in a separate patch though.