[webkit-reviews] review granted: [Bug 184761] [WinCairo][EWS] Build bot should clean user temp directory each time. : [Attachment 338288] Patch

[bugzilla-daemon at webkit.org]

Lucas Forschler <lforschler at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 184761: [WinCairo][EWS] Build bot should clean user temp directory each
time.
https://bugs.webkit.org/show_bug.cgi?id=184761

Attachment 338288: Patch

https://bugs.webkit.org/attachment.cgi?id=338288&action=review




--- Comment #5 from Lucas Forschler <lforschler at apple.com> ---
Comment on attachment 338288
  --> https://bugs.webkit.org/attachment.cgi?id=338288
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338288&action=review

I'm not a powershell expert, but this otherwise seems fine.

> Tools/EWSTools/Start-Queue.ps1:58
> +    Write-Host 'Cleaning user temp directory';

I would output the temp folder here, just to make it clear what directory you
are working on.

> Tools/EWSTools/Start-Queue.ps1:67
> +	   $filesRemoved++;

if $file is a directory, it looks like you'll attempt to remove it recursively,
but only increment $filesremoved once... so this count may not be accurate.
Otherwise, I'm not sure what the purpose of the -Recurse is here on the
Remove-Item line.

> Tools/EWSTools/Start-Queue.ps1:68
> +	   Write-Host ('Removed file {0}' -f  $file.FullName)

This is going to be pretty verbose... do you actually want this list? Or was
this just for debugging?