[webkit-reviews] review granted: [Bug 184721] The InternalFunction hierarchy should be in IsoSubspaces : [Attachment 338189] the patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 184721: The InternalFunction hierarchy should be in IsoSubspaces
https://bugs.webkit.org/show_bug.cgi?id=184721

Attachment 338189: the patch

https://bugs.webkit.org/attachment.cgi?id=338189&action=review




--- Comment #16 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 338189
  --> https://bugs.webkit.org/attachment.cgi?id=338189
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338189&action=review

> Source/JavaScriptCore/heap/IsoSubspacePerVM.cpp:65
> +    if (result) {

style nit: I feel result.isNewEntry is easier to read than this (I just had to
look up that AddResult has operator bool that returns newEntry).