[webkit-reviews] review granted: [Bug 184744] Propagate stack overflow and OOM when compiling builtins at runtime : [Attachment 338233] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 18 11:54:17 PDT 2018


Mark Lam <mark.lam at apple.com> has granted JF Bastien <jfbastien at apple.com>'s
request for review:
Bug 184744: Propagate stack overflow and OOM when compiling builtins at runtime
https://bugs.webkit.org/show_bug.cgi?id=184744

Attachment 338233: patch

https://bugs.webkit.org/attachment.cgi?id=338233&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 338233
  --> https://bugs.webkit.org/attachment.cgi?id=338233
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338233&action=review

As per our offline discussion, since this issue does not reproduce on Darwin,
can you please hack the code to force a StackOverflow error after some N number
of recursions, and verify that the fix does work as intended, and that it
doesn't result in some unexpected failure condition?

r=me with fixes and testing.

> JSTests/ChangeLog:9
> +	   * stress/create-default-constuctor-near-stack-limit.js: Added.

Please fix the name of this file: /constuctor/constructor/.

> Source/JavaScriptCore/ChangeLog:17
> +	   done in two ways:

nit: I would say "handled" instead of "done".

> Source/JavaScriptCore/ChangeLog:20
> +	   users the error type), which then puts a JS error on the execution

typo: /users/uses/?


More information about the webkit-reviews mailing list