[webkit-reviews] review granted: [Bug 184736] [WebAssembly][Modules] Import globals from wasm modules : [Attachment 338216] Patch

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 184736: [WebAssembly][Modules] Import globals from wasm modules
https://bugs.webkit.org/show_bug.cgi?id=184736

Attachment 338216: Patch

https://bugs.webkit.org/attachment.cgi?id=338216&action=review




--- Comment #2 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 338216
  --> https://bugs.webkit.org/attachment.cgi?id=338216
Patch

Could you test that i64 fails?
Also, can you test f32 / f64, and especially that exporting a non-canonical NaN
gets it canonicalized?

Otherwise r=me