[webkit-reviews] review granted: [Bug 184515] Add support for converting a local window to a remote window : [Attachment 338144] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 184515: Add support for converting a local window to a remote window
https://bugs.webkit.org/show_bug.cgi?id=184515

Attachment 338144: Patch

https://bugs.webkit.org/attachment.cgi?id=338144&action=review




--- Comment #36 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 338144
  --> https://bugs.webkit.org/attachment.cgi?id=338144
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338144&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:2441
> +    m_mainFrameWindowCreationHandler = [this, previousProcess =
WTFMove(previousProcess), previousFrameIdentifier =
*previousFrameIdentifier](const GlobalWindowIdentifier& windowIdentifier) {

I think it's clearer to call previousProcess as frameOwnerProcess and
ownerFrameIdentifier, etc..
since what's important here is that it's the process/frame which opened this
frame.