[webkit-reviews] review granted: [Bug 184719] Don't activate selection on become first responder : [Attachment 338164] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 184719: Don't activate selection on become first responder
https://bugs.webkit.org/show_bug.cgi?id=184719

Attachment 338164: Patch

https://bugs.webkit.org/attachment.cgi?id=338164&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 338164
  --> https://bugs.webkit.org/attachment.cgi?id=338164
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338164&action=review

> Source/WebKit/ChangeLog:9
> +	   as there are not guaranteed to have selection rects immediately due
to async/two process architecture. The selection

as there?

> Source/WebKit/ChangeLog:11
> +	   in the past because this selection assistant was only for editable
text, which would immediately set a carat, which 

caret! This is not gold.

> Source/WebKit/ChangeLog:12
> +	   counted at a selection. Now that this is for non-editable text as
well, activating the selection is problematic.

Counted!?