[webkit-reviews] review granted: [Bug 184462] Web Automation: simulated mouse interactions should not be done until associated DOM events have been dispatched : [Attachment 338027] Proposed Fix

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 184462: Web Automation: simulated mouse interactions should not be done
until associated DOM events have been dispatched
https://bugs.webkit.org/show_bug.cgi?id=184462

Attachment 338027: Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=338027&action=review




--- Comment #8 from Tim Horton <thorton at apple.com> ---
Comment on attachment 338027
  --> https://bugs.webkit.org/attachment.cgi?id=338027
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=338027&action=review

> Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:1440
> +		       .setY(y - page->topContentInset())

Somehow this topContentInset() is surprising -- do we not have functions to map
between whatever relevant coordinate spaces are involved?