[webkit-reviews] review denied: [Bug 184312] [INTL] Implement Intl.PluralRules : [Attachment 338137] Patch

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has denied Andy VanWagoner
<thetalecrafter at gmail.com>'s request for review:
Bug 184312: [INTL] Implement Intl.PluralRules
https://bugs.webkit.org/show_bug.cgi?id=184312

Attachment 338137: Patch

https://bugs.webkit.org/attachment.cgi?id=338137&action=review




--- Comment #21 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 338137
  --> https://bugs.webkit.org/attachment.cgi?id=338137
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338137&action=review

> Source/JavaScriptCore/runtime/IntlObject.cpp:118
> +    putDirectWithoutTransition(vm, vm.propertyNames->PluralRules,
pluralRulesConstructor, static_cast<unsigned>(PropertyAttribute::DontEnum));

You need to do this conditionally under a runtime flag:
https://lists.webkit.org/pipermail/webkit-dev/2018-April/029943.html

> Source/JavaScriptCore/runtime/IntlPluralRules.cpp:167
> +	   m_maximumSignificantDigits =
std::optional<unsigned>(maximumSignificantDigits);

Why cast here? You can just assign an unsigned to an optional<unsigned>.