[webkit-reviews] review requested: [Bug 184672] PutStackSinkingPhase should know that KillStack means ConflictingFlush : [Attachment 338143] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 17 12:37:10 PDT 2018


Filip Pizlo <fpizlo at apple.com> has asked  for review:
Bug 184672: PutStackSinkingPhase should know that KillStack means
ConflictingFlush
https://bugs.webkit.org/show_bug.cgi?id=184672

Attachment 338143: the patch

https://bugs.webkit.org/attachment.cgi?id=338143&action=review




--- Comment #3 from Filip Pizlo <fpizlo at apple.com> ---
Created attachment 338143

  --> https://bugs.webkit.org/attachment.cgi?id=338143&action=review

the patch

Decided to be even more conservative and change clobberize for KillStack.

This is all perf neutral so it's probably worth it for the correctness.


More information about the webkit-reviews mailing list