[webkit-reviews] review granted: [Bug 184554] Implement checked cast for DDResultRef once DDResultGetTypeID() is available : [Attachment 337828] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 17 09:20:28 PDT 2018


Brent Fulgham <bfulgham at webkit.org> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 184554: Implement checked cast for DDResultRef once DDResultGetTypeID() is
available
https://bugs.webkit.org/show_bug.cgi?id=184554

Attachment 337828: Patch

https://bugs.webkit.org/attachment.cgi?id=337828&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 337828
  --> https://bugs.webkit.org/attachment.cgi?id=337828
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337828&action=review

r=me

> Source/WebCore/editing/cocoa/DataDetection.mm:87
> +	   DDResultRef result =
checked_cf_cast<DDResultRef>(CFArrayGetValueAtIndex(results.get(), i));

Nice!


More information about the webkit-reviews mailing list