[webkit-reviews] review granted: [Bug 184664] [macOS] Don't establish unneeded Dock connections : [Attachment 338117] Patch

[bugzilla-daemon at webkit.org]

Per Arne Vollan <pvollan at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 184664: [macOS] Don't establish unneeded Dock connections
https://bugs.webkit.org/show_bug.cgi?id=184664

Attachment 338117: Patch

https://bugs.webkit.org/attachment.cgi?id=338117&action=review




--- Comment #16 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 338117
  --> https://bugs.webkit.org/attachment.cgi?id=338117
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338117&action=review

R=me.

> Source/WebKit/PluginProcess/mac/PluginProcessMac.mm:-532
> -#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
> -    // We don't need to talk to the dock.
> -    if ([NSApplication
respondsToSelector:@selector(_preventDockConnections)])
> -	   [NSApplication _preventDockConnections];
> -#endif

Should we also remove this code from the WebContent process?