[webkit-reviews] review granted: [Bug 184674] Commit order should always be returned by api. : [Attachment 338061] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted dewei_zhu at apple.com's request for
review:
Bug 184674: Commit order should always be returned by api.
https://bugs.webkit.org/show_bug.cgi?id=184674

Attachment 338061: Patch

https://bugs.webkit.org/attachment.cgi?id=338061&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 338061
  --> https://bugs.webkit.org/attachment.cgi?id=338061
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338061&action=review

> Websites/perf.webkit.org/public/api/measurement-set.php:223
> +	       $order = !strlen($trimmed_order) ? NULL :
intval($trimmed_order);

I think it's a little more straight forward to do: strlen($trimmed_order) ?
intval($trimmed_order) : NULL.