[webkit-reviews] review granted: [Bug 184653] Add bindings code for RemoteDOMWindow : [Attachment 338030] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 184653: Add bindings code for RemoteDOMWindow
https://bugs.webkit.org/show_bug.cgi?id=184653

Attachment 338030: Patch

https://bugs.webkit.org/attachment.cgi?id=338030&action=review




--- Comment #9 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 338030
  --> https://bugs.webkit.org/attachment.cgi?id=338030
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338030&action=review

> Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:82
> +template <IsRemoteDOMWindow isRemoteDOMWindow>

I think I'd prefer having DOMWindowType / DOMWindowLocation enum with Remote
and Local as values.

> Source/WebCore/bindings/js/JSRemoteDOMWindowBase.h:37
> +class WEBCORE_EXPORT JSRemoteDOMWindowBase : public JSDOMGlobalObject {

Why is this class introduced / needed? Please explain it in the change log.