[webkit-reviews] review granted: [Bug 184675] [iOS] Enable WKPDFView by default : [Attachment 338063] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 184675: [iOS] Enable WKPDFView by default
https://bugs.webkit.org/show_bug.cgi?id=184675

Attachment 338063: Patch

https://bugs.webkit.org/attachment.cgi?id=338063&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 338063
  --> https://bugs.webkit.org/attachment.cgi?id=338063
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338063&action=review

> Source/WTF/wtf/FeatureDefines.h:170
> +#if PLATFORM(IOS) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV) &&
!ENABLE(MINIMAL_SIMULATOR) && __IPHONE_OS_VERSION_MIN_REQUIRED < 120000

Another way to do this would be to put this after the ENABLE_WKPDFVIEW
paragraph and do it only #if !ENABLE(WKPFDVIEW).

I’ll note that if someone sets both ENABLE_WKLEGACYPDFVIEW and
ENABLE_WKPDFVIEW, we do allow nonsense combinations like having both enabled.
Not sure what our usual style/strategy is for this. Could imagine using #error
or something.