[webkit-reviews] review denied: [Bug 184669] Add system trace points for process launch and for initializeWebProcess : [Attachment 338053] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Saam Barati
<sbarati at apple.com>'s request for review:
Bug 184669: Add system trace points for process launch and for
initializeWebProcess
https://bugs.webkit.org/show_bug.cgi?id=184669

Attachment 338053: patch

https://bugs.webkit.org/attachment.cgi?id=338053&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 338053
  --> https://bugs.webkit.org/attachment.cgi?id=338053
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338053&action=review

> Source/WebKit/WebProcess/WebProcess.cpp:282
> +    TraceScope traceScope(ProcessLaunchStart, ProcessLaunchEnd);

You're using the same codes for both UI and web process sides. I think this
will result in confusion; you should use different codes.