[webkit-reviews] review granted: [Bug 184600] [WebAssembly][Modules] Prototype wasm import : [Attachment 337993] Patch

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 184600: [WebAssembly][Modules] Prototype wasm import
https://bugs.webkit.org/show_bug.cgi?id=184600

Attachment 337993: Patch

https://bugs.webkit.org/attachment.cgi?id=337993&action=review




--- Comment #6 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 337993
  --> https://bugs.webkit.org/attachment.cgi?id=337993
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337993&action=review

Very cool!

No need for a runtime flag because this only works in the shell, right?

r=me otherwise

> Source/JavaScriptCore/jsc.cpp:978
> +    Vector<uint8_t> utf8;

Rename it to something else than utf8, since it's just bytes in wasm.

> Source/JavaScriptCore/runtime/AbstractModuleRecord.cpp:795
> +}

lol "virtual" ;-)