[webkit-reviews] review granted: [Bug 183153] Animated GIFs with finite looping are falling one loop short : [Attachment 337918] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 183153: Animated GIFs with finite looping are falling one loop short
https://bugs.webkit.org/show_bug.cgi?id=183153

Attachment 337918: Patch

https://bugs.webkit.org/attachment.cgi?id=337918&action=review




--- Comment #16 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 337918
  --> https://bugs.webkit.org/attachment.cgi?id=337918
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337918&action=review

> Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:239
> +    static std::tuple<CFStringRef, CFStringRef, bool> repetitionKeys[] = {
> +	   std::make_tuple(kCGImagePropertyGIFDictionary,
kCGImagePropertyGIFLoopCount, true),
> +	   std::make_tuple(kCGImagePropertyPNGDictionary,
WebCoreCGImagePropertyAPNGLoopCount, false)
> +    };

I don't find this tuple stuff much clearer than the existing code, especially
as you have to add the hard-to-grok bool at the end.