[webkit-reviews] review granted: [Bug 184647] [GLIB] Add API to query, delete and enumerate properties : [Attachment 337994] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 16 07:47:02 PDT 2018


Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 184647: [GLIB] Add API to query, delete and enumerate properties
https://bugs.webkit.org/show_bug.cgi?id=184647

Attachment 337994: Patch

https://bugs.webkit.org/attachment.cgi?id=337994&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 337994
  --> https://bugs.webkit.org/attachment.cgi?id=337994
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337994&action=review

> Source/JavaScriptCore/API/glib/JSCValue.cpp:742
> + * Get whether @value has propety with @name.

property

> Source/JavaScriptCore/API/glib/JSCValue.cpp:758
> +
> +

Remove extra blank line

> Source/JavaScriptCore/API/glib/JSCValue.cpp:785
> +
> +

Ditto (you do want only one blank line here, right?)


More information about the webkit-reviews mailing list