[webkit-reviews] review granted: [Bug 184415] Change Event's returnValue so it doesn't expose a new primitive : [Attachment 337925] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 184415: Change Event's returnValue so it doesn't expose a new primitive
https://bugs.webkit.org/show_bug.cgi?id=184415

Attachment 337925: Patch

https://bugs.webkit.org/attachment.cgi?id=337925&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 337925
  --> https://bugs.webkit.org/attachment.cgi?id=337925
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337925&action=review

> Source/WebCore/dom/Event.h:99
> +    WEBCORE_EXPORT void setLegacyReturnValue(bool);

Why less inlining? I would have left everything in the header and marked
inline.