[webkit-reviews] review granted: [Bug 184630] Function.prototype.caller shouldn't return generator bodies : [Attachment 337961] the patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 184630: Function.prototype.caller shouldn't return generator bodies
https://bugs.webkit.org/show_bug.cgi?id=184630

Attachment 337961: the patch

https://bugs.webkit.org/attachment.cgi?id=337961&action=review




--- Comment #2 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 337961
  --> https://bugs.webkit.org/attachment.cgi?id=337961
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337961&action=review

r=me, nice.

> JSTests/stress/function-caller-generator-body.js:24
> +})();

Can you add a test for,

1. Async functions, which uses generators internally
2. generator method functions like

class A {
    *gen() {
	...
    }
}

var a = new A();
var gen = a.gen();