[webkit-reviews] review granted: [Bug 184591] Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame : [Attachment 337916] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 184591: Split WindowProxy handling out of ScriptController and into a new
class owned by AbstractFrame
https://bugs.webkit.org/show_bug.cgi?id=184591

Attachment 337916: Patch

https://bugs.webkit.org/attachment.cgi?id=337916&action=review




--- Comment #8 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 337916
  --> https://bugs.webkit.org/attachment.cgi?id=337916
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337916&action=review

> Source/WebCore/bindings/js/WindowProxyController.h:41
> +    Vector<JSC::Strong<JSDOMWindowProxy>> windowProxiesAsVector() const;

I kind of feel this function should have the word "copy" somewhere in its name,
but I can't think of one that isn't overly verbose.

> Source/WebCore/bindings/js/WindowProxyController.h:43
> +    ProxyMap releaseWindowProxies() { return std::exchange(m_windowProxies,
ProxyMap()); }

Does anyone call this?

> Source/WebCore/bindings/js/WindowProxyController.h:44
> +    void setWindowProxies(ProxyMap&& windowProxies) { m_windowProxies =
WTFMove(windowProxies); }

Does anyone call this?