[webkit-reviews] review granted: [Bug 184517] input.webkitEntries does not work as expected when folder contains accented chars : [Attachment 337822] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 13 10:04:20 PDT 2018


Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 184517: input.webkitEntries does not work as expected when folder contains
accented chars
https://bugs.webkit.org/show_bug.cgi?id=184517

Attachment 337822: Patch

https://bugs.webkit.org/attachment.cgi?id=337822&action=review




--- Comment #25 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 337822
  --> https://bugs.webkit.org/attachment.cgi?id=337822
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337822&action=review

> Source/WebCore/platform/posix/FileSystemPOSIX.cpp:354
> +    return String::fromUTF8(dirname(fsRep.mutableData()));

Maybe we should just call data instead of mutableData now.


More information about the webkit-reviews mailing list