[webkit-reviews] review denied: [Bug 184582] Add SetCallee as DFG-Operation : [Attachment 337883] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has denied Dominik Inführ
<dinfuehr at igalia.com>'s request for review:
Bug 184582: Add SetCallee as DFG-Operation
https://bugs.webkit.org/show_bug.cgi?id=184582

Attachment 337883: Patch

https://bugs.webkit.org/attachment.cgi?id=337883&action=review




--- Comment #6 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 337883
  --> https://bugs.webkit.org/attachment.cgi?id=337883
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337883&action=review

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:2455
> +    case SetCallee:

Do we not model Callee is a variable?

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1399
> +	       addToGraph(SetCallee, OpInfo(bitwise_cast<intptr_t>(function)));

This doesn’t look completely right. You need to always do this if you’re
looping back to the machine call frame (regardless of the variant being a
constant value). Also, you need to do this anytime you loop back to an inline
frame that has its callee in a stack slot.